Skip to content

fix: var read in own body#454

Merged
DylanPiercey merged 1 commit intomainfrom
fix-var-in-body-reads
Feb 3, 2026
Merged

fix: var read in own body#454
DylanPiercey merged 1 commit intomainfrom
fix-var-in-body-reads

Conversation

@DylanPiercey
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

🦋 Changeset detected

Latest commit: 6541a8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/language-server Patch
@marko/language-tools Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 8a76656 into main Feb 3, 2026
5 checks passed
@DylanPiercey DylanPiercey deleted the fix-var-in-body-reads branch February 3, 2026 22:02
@github-actions github-actions bot mentioned this pull request Feb 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

This change updates Marko-related packages and development tools. It includes a changeset documenting patch version updates for multiple Marko packages and VSCode integration to fix a regression with recursive define tag types. A new generic type utility function is added to the Marko type declarations. The script extractor logic is refactored to consolidate handling of hoisted code and tag variable mutations, with changes to how mutations are wired to render results.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a pull request description explaining the fix, the regression it addresses, and the impact on tag variable handling in body content.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: var read in own body' directly describes the main fix: addressing how tag variables are read within their own body content, which aligns with the changeset description about fixing a regression with recursive define tag types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-var-in-body-reads

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Feb 27, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Feb 27, 2026
@DylanPiercey DylanPiercey self-assigned this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant