Skip to content

fix: unecessary const native tag codegen#456

Merged
DylanPiercey merged 1 commit intomainfrom
fix-unneeded-native-tag-render-vars
Feb 4, 2026
Merged

fix: unecessary const native tag codegen#456
DylanPiercey merged 1 commit intomainfrom
fix-unneeded-native-tag-render-vars

Conversation

@DylanPiercey
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: 010408b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/language-server Patch
@marko/language-tools Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 0750620 into main Feb 4, 2026
4 checks passed
@DylanPiercey DylanPiercey deleted the fix-unneeded-native-tag-render-vars branch February 4, 2026 23:13
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

A new changeset file documents patch-level version updates for @marko/language-server, @marko/language-tools, @marko/type-check, and marko-vscode packages. The primary code change modifies the script extraction logic in language-tools to conditionally emit render variable declarations. Previously, the render variable declaration was always emitted; now it is only emitted when a tag requires hoisting or is not an HTML tag.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-unneeded-native-tag-render-vars

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot mentioned this pull request Feb 4, 2026
@DylanPiercey DylanPiercey self-assigned this Feb 27, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant