Skip to content

chore: run build step when installed via git reference#16

Merged
DylanPiercey merged 1 commit intomarko-js:mainfrom
kanashimia:fix-installation-form-github-reference
Oct 25, 2025
Merged

chore: run build step when installed via git reference#16
DylanPiercey merged 1 commit intomarko-js:mainfrom
kanashimia:fix-installation-form-github-reference

Conversation

@kanashimia
Copy link
Copy Markdown
Contributor

@kanashimia kanashimia commented Oct 25, 2025

Fixes installation via npm from Git URIs like these: https://github.com/web-fragments/web-fragments/blob/8a1f5a8ef83d13313f638ae28ce2822397db718c/packages/reframed/package.json#L16
Taken from web-fragments fork: be7248e
Isn't really needed much, but is a minor improvement for those who want to fork this library.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 25, 2025

⚠️ No Changeset found

Latest commit: a1d1cf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey
Copy link
Copy Markdown
Contributor

@kanashimia this looks fine to me. However I don't think it needs a changeset / a release?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.33%. Comparing base (020d50b) to head (de234f9).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   82.72%   78.33%   -4.40%     
==========================================
  Files           1        1              
  Lines         110      120      +10     
  Branches       30       35       +5     
==========================================
+ Hits           91       94       +3     
- Misses         16       22       +6     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kanashimia
Copy link
Copy Markdown
Contributor Author

@DylanPiercey Yeah, I don't think changeset is needed. Just a sec I will remove it.

Some bug in the CI 🙄

@kanashimia kanashimia force-pushed the fix-installation-form-github-reference branch from de234f9 to a1d1cf7 Compare October 25, 2025 22:38
@DylanPiercey DylanPiercey merged commit 4e87659 into marko-js:main Oct 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants