Fix UnityObject reference serialization in Placeholders#1420
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🔒 Rejected & Closed: PR contains unresolvable merge conflicts with current main HEAD. |
|
🔒 Rejected & Closed: PR contains unresolvable merge conflicts with current main HEAD. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. Let me know if you need any other fixes. |
1 similar comment
Understood. Acknowledging that this work is now obsolete and stopping work on this task. Let me know if you need any other fixes. |
|
|
Understood. Acknowledging that this work is now obsolete and stopping work on this task. Let me know if you need any other fixes. |
1 participant
🎯 What: Implemented serialization of
UnityObjectreferences inside theMapMagic.Nodes.Placeholdersby storingorigUniObjinsideGenericPlaceholderand assigning it manually toSerObjectinside the custom serialization hooks.💡 Why:
UnityObjectreferences were not being serialized (as mentioned by the TODO), preventing proper saving ofGenericPlaceholdernodes.✅ Verification: Verified compilation and no regression by running full verify sweep.
✨ Result: Placeholders now correctly serialize
UnityObjectreferences.PR created automatically by Jules for task 16878339498043222893 started by @marko1olo