fix(shader): normalize view direction in Universal pipeline#1431
fix(shader): normalize view direction in Universal pipeline#1431marko1olo wants to merge 1 commit into
Conversation
Replaced direct assignment of input.viewDirectionWS to output.WorldSpaceViewDirection with normalize(input.viewDirectionWS) in OceanFramework_Generated.shader. This addresses the TODO comment indicating it wasn't normalized by default in the universal pipeline, ensuring consistent behavior across rendering pipelines.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced direct assignment of
input.viewDirectionWStooutput.WorldSpaceViewDirectionwithnormalize(input.viewDirectionWS)inOceanFramework_Generated.shader. This addresses the TODO comment indicating it wasn't normalized by default in the universal pipeline, ensuring consistent behavior across rendering pipelines.PR created automatically by Jules for task 12721784473288633058 started by @marko1olo