Skip to content

Fix unnormalized view direction in HD/URP in OceanFramework shader#1437

Open
marko1olo wants to merge 1 commit into
mainfrom
jules/fix-unnormalized-view-direction-hd-urp-10134758252134247888
Open

Fix unnormalized view direction in HD/URP in OceanFramework shader#1437
marko1olo wants to merge 1 commit into
mainfrom
jules/fix-unnormalized-view-direction-hd-urp-10134758252134247888

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

This PR addresses an issue where output.WorldSpaceViewDirection was being assigned an unnormalized input.viewDirectionWS in Assets/Crest/Crest/Shaders/ShadergraphFramework/OceanFramework_Generated.shader. A comment inside the shader code stated //TODO: by default normalized in HD, but not in universal. To ensure consistent behavior across different render pipelines, input.viewDirectionWS is now explicitly normalized during the assignment. All occurrences across the shader have been updated.

Verification sweep using Tools/RunFullVerifySweep.py passed with no introduced regressions.


PR created automatically by Jules for task 10134758252134247888 started by @marko1olo

Normalize input.viewDirectionWS for output.WorldSpaceViewDirection across the OceanFramework_Generated shader
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant