Normalize view direction in OceanFramework_Generated shader#1439
Normalize view direction in OceanFramework_Generated shader#1439marko1olo wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🔒 Rejected & Closed: PR contains unresolvable merge conflicts with current main HEAD. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
The
OceanFramework_Generated.shaderhad a recurring issue noted by aTODOcomment: "by default normalized in HD, but not in universal", regardinginput.viewDirectionWS.This patch addresses the bug by explicitly using the
normalize()function when assigninginput.viewDirectionWStooutput.WorldSpaceViewDirectionacross all 9 generated permutations within the file. This ensures proper normalization is consistently applied in both HDRP and URP.All pre-existing passing tests have been verified with no regressions using
RunFullVerifySweep.pyafter removing temporary artifacts.PR created automatically by Jules for task 17239278237190025341 started by @marko1olo