Skip to content

Normalize view direction in OceanFramework_Generated shader#1439

Closed
marko1olo wants to merge 1 commit into
mainfrom
fix/shader-view-direction-normalization-17239278237190025341
Closed

Normalize view direction in OceanFramework_Generated shader#1439
marko1olo wants to merge 1 commit into
mainfrom
fix/shader-view-direction-normalization-17239278237190025341

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

The OceanFramework_Generated.shader had a recurring issue noted by a TODO comment: "by default normalized in HD, but not in universal", regarding input.viewDirectionWS.

This patch addresses the bug by explicitly using the normalize() function when assigning input.viewDirectionWS to output.WorldSpaceViewDirection across all 9 generated permutations within the file. This ensures proper normalization is consistently applied in both HDRP and URP.

All pre-existing passing tests have been verified with no regressions using RunFullVerifySweep.py after removing temporary artifacts.


PR created automatically by Jules for task 17239278237190025341 started by @marko1olo

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@marko1olo

Copy link
Copy Markdown
Owner Author

🔒 Rejected & Closed: PR contains unresolvable merge conflicts with current main HEAD.

@marko1olo marko1olo closed this Jul 23, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

🔒 Rejected & Closed: PR contains unresolvable merge conflicts with current main HEAD.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant