Use generic interface for node types#1475
Conversation
Co-authored-by: marko1olo <96879250+marko1olo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
✅ Confirmed Integrated: Code is present in |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Replaced hard-coded node types with a generic
IGeneratesVirtualTextureFeedbackinterface inVirtualTexturingFeedbackUtils.This patch:
IGeneratesVirtualTextureFeedbackinterface to unify how virtual texturing node classes provide feedback variables.SampleVirtualTextureNodeandSubGraphNodeto implement the interface.VirtualTexturingFeedbackUtils.csto query and use the interface rather than performing explicit types checks, resolving technical debt and increasing system extensibility.GraphUtil.cs(FindDownStreamNodesOfType) to supportclass(including interfaces).PR created automatically by Jules for task 11557214558165152221 started by @marko1olo