Skip to content

Use generic interface for node types#1475

Closed
marko1olo wants to merge 1 commit into
mainfrom
jules-11557214558165152221-256c55c5
Closed

Use generic interface for node types#1475
marko1olo wants to merge 1 commit into
mainfrom
jules-11557214558165152221-256c55c5

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

Replaced hard-coded node types with a generic IGeneratesVirtualTextureFeedback interface in VirtualTexturingFeedbackUtils.

This patch:

  • Creates IGeneratesVirtualTextureFeedback interface to unify how virtual texturing node classes provide feedback variables.
  • Modifies SampleVirtualTextureNode and SubGraphNode to implement the interface.
  • Adapts VirtualTexturingFeedbackUtils.cs to query and use the interface rather than performing explicit types checks, resolving technical debt and increasing system extensibility.
  • Updates generic constraints in GraphUtil.cs (FindDownStreamNodesOfType) to support class (including interfaces).

PR created automatically by Jules for task 11557214558165152221 started by @marko1olo

Co-authored-by: marko1olo <96879250+marko1olo@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@marko1olo

Copy link
Copy Markdown
Owner Author

Confirmed Integrated: Code is present in main branch (Direct commit match in git log). Closing PR.

@marko1olo marko1olo closed this Jul 23, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Confirmed Integrated: Code is present in main branch (Direct commit match in git log). Closing PR.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant