🧪 Test shutdown_image_executors() for proper thread pool cleanup#1018
🧪 Test shutdown_image_executors() for proper thread pool cleanup#1018marko1olo wants to merge 1 commit into
Conversation
Co-authored-by: marko1olo <96879250+marko1olo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Added unit tests to test the
shutdown_image_executorsfunction inDubsite_tgach/image_processing.py.📊 Coverage: Tests verify the three main branches: both executor pools exist, one executor pool exists, and both executor pools are None. It validates that
.shutdown()is correctly called and that global executor properties are properly cleared out.✨ Result: Improved test coverage and ensured regression safety for thread pool cleanup execution logic.
PR created automatically by Jules for task 13707712160485298518 started by @marko1olo