Add support for msgpack strings as LXMF dest names#32
Open
DanBeard wants to merge 1 commit intomarkqvist:masterfrom
Open
Add support for msgpack strings as LXMF dest names#32DanBeard wants to merge 1 commit intomarkqvist:masterfrom
DanBeard wants to merge 1 commit intomarkqvist:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check for msgpack utf-8 strings in case an LXMF client sent that for their name. This is important since not all msgpack libraries support binary strings. (like ArduinoJson 6.x.x that microReticulum uses) and the names are immediately decoded into a utf-8 string anyway after being unpacked.