feat: Add external stamp generator support for Android#38
Open
torlando-tech wants to merge 1 commit intomarkqvist:masterfrom
Open
feat: Add external stamp generator support for Android#38torlando-tech wants to merge 1 commit intomarkqvist:masterfrom
torlando-tech wants to merge 1 commit intomarkqvist:masterfrom
Conversation
Add set_external_generator() function to LXStamper.py that allows platforms like Android to provide a native stamp generator callback. This bypasses Python multiprocessing which fails on Android due to lack of sem_open support and aggressive process killing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
Great idea. I'll look at merging this during the next round of work on LXMF, and should have it ready for the next release. Hope you can just use it internally in Columba until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into issues with multiprocessing in chaquopy where stamp generation would fail due to Android's aggressive process culling. I explored changing python's multiprocessing to threads, but it seems there is some GIL limitation that results in only one thread running at a time, which greatly slows it down.
This change lets Columba do stamp generation in Kotlin, which ends up roughly twice as fast as the python version.
No worries if you'd rather not merge this (or do it differently!), I don't mind maintaining a fork for Columba.
Thank you!