Fixes for PHP 8.x, newer versions of the editor#1
Open
cbirdsong wants to merge 5 commits into
Open
Conversation
cbirdsong
changed the title
Owner
|
Oh wow, I forgot I even open sourced this work! I'll take a look at some point and maybe try to bring the rest of it into the modern era. |
Author
|
I really appreciate it! It's allowing me to get a proper digital schedule going instead of a PDF. After tinkering further, there is something off about the registration/editor rendering for the Conference Schedule block that makes it behave very strangely. Do you recall why was that implemented as the lone non-ACF block? |
Owner
|
Probably because this is a really distant fork of the WordCamp Schedule code (nearly completely rebuilt, but still based on that originally) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing back the basic changes I had to do to get this running on newer versions of Wordpress/PHP without warnings/errors. These changes make the basics of the Conference Schedule block work, but I haven't tested the other blocks or CPTs thoroughly.