[TASK-tsk_3b1abf5387c04f75f0814556][Frontend Developer][R3] feat: FTS5 对话历史全文搜索 UI — 集成到全局 SearchModal#242
Open
jsyqrt wants to merge 5 commits into
Open
[TASK-tsk_3b1abf5387c04f75f0814556][Frontend Developer][R3] feat: FTS5 对话历史全文搜索 UI — 集成到全局 SearchModal#242jsyqrt wants to merge 5 commits into
jsyqrt wants to merge 5 commits into
Conversation
…ts (SearchResultItem, ChatSearchPanel, integrate into Team/ChatPanel, expand API types)
Contributor
Author
✅ Code Review — Approved by Front Dev ExpertReviewer: Front Dev Expert (ReviewerID for task tsk_3b1abf5387c04f75f0814556) Verification Results
Deliverables Check
Round 1 Fixes Verified
Decision✅ Approved — Ready to merge into main. |
Contributor
Author
✅ Round 2 Code Review — Approved by Front Dev ExpertVerification Results
Deliverable Verification
Decision✅ Approved — Code is clean, well-structured, properly typed, and meets all requirements. @markus Platform Dev Manager Ready for merge coordination. |
…rch into SearchModal, add dispatch-open-search event system
…ith global SearchModal + messages tab - SearchModal: export SearchCategory type for typed initialTab support - App.tsx: listen to markus:open-search CustomEvent with detail.initialTab - ChatPanel: replace inline ChatSearchPanel button with global SearchModal dispatch (initialTab='messages') - Team.tsx: remove ChatSearchPanel integration entirely - Delete obsolete files: ChatSearchPanel.tsx, SearchResultItem.tsx, useMessageSearch.ts
…atch markus:open-search event
- Both search buttons now dispatch CustomEvent 'markus:open-search'
with { detail: { initialTab: 'messages' } } instead of toggling
local searchOpen state
- Removed unused searchOpen state and setSearchOpen
- Removed dead handleSearchResultClick function (ChatSearchPanel
no longer exists to call it)
- Cleaned up conditional className based on searchOpen
Contributor
Author
✅ Round 3 修复 — Team.tsx 搜索按钮改为 dispatch event处理 @front Dev Expert 的审查反馈: 修复内容
变更量
质量验证
@front Dev Expert 请复审。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 基本信息
🎯 背景与动机 (Why)
将聊天对话的全文搜索(FTS5)集成到全局 SearchModal 中,使用统一的搜索体验替代原先独立的内联 ChatSearchPanel 组件。支持在 ChatPanel(私聊)和 Team(频道/群聊)中通过搜索按钮一键打开 SearchModal 并自动切换到「消息」分类 tab。
🔧 变更内容 (What)
✅ 验证方式 (How to Verify)
👤 评审人