Add Swift Package Manager support#118
Open
oliviermartin wants to merge 1 commit into
Open
Conversation
Open
Author
|
Should implement #115 |
AvdLee
requested changes
Jun 15, 2018
AvdLee
left a comment
AvdLee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR! I do miss some editions to the readme to update on the Swift Package Manager support. Also, some feedback inline.
| header "unzip.h" | ||
| header "zip.h" | ||
| header "../unzip.h" | ||
| header "../zip.h" |
Collaborator
There was a problem hiding this comment.
Why are you updating the module map paths here? Are these necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Swift Package Manager (SPM)