Skip to content

fix: 🐞 resurrect material recipe filter form #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjaaidi merged 3 commits into from
Mar 11, 2026
Merged

fix: 🐞 resurrect material recipe filter form #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98d1edc
fix: 🐞 resurrect material recipe filter form
yjaaidi Mar 11, 2026
40c2073
test: ✅ update snapshots
Mar 11, 2026
ff6e35b
refactor: 🛠️ propagate changes
yjaaidi Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/401-recipe-filter-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
9 changes: 6 additions & 3 deletions apps/401-recipe-filter-starter/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { ChangeDetectionStrategy, Component, output } from '@angular/core';
import { ChangeDetectionStrategy, Component, model } from '@angular/core';
import { FormField, FormRoot } from '@angular/forms/signals';
import { RecipeFilterCriteria } from './recipe-filter-criteria';
import {
createDefaultRecipeFilterCriteria,
RecipeFilterCriteria,
} from './recipe-filter-criteria';

@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
Expand All @@ -9,5 +12,5 @@ import { RecipeFilterCriteria } from './recipe-filter-criteria';
template: ` &lt;🚧 wm-recipe-filter&gt; `,
})
export class RecipeFilter {
filterChange = output<RecipeFilterCriteria>();
filter = model<RecipeFilterCriteria>(createDefaultRecipeFilterCriteria());
}
1 change: 0 additions & 1 deletion apps/402-recipe-search-filter-interaction-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
1 change: 0 additions & 1 deletion apps/402-recipe-search-filter-interaction-starter/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
1 change: 0 additions & 1 deletion apps/403-recipe-search-add-button-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
1 change: 0 additions & 1 deletion apps/403-recipe-search-add-button-starter/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
50 changes: 27 additions & 23 deletions apps/404-recipe-filter-material-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChangeDetectionStrategy, Component, model } from '@angular/core';
import { form, FormField, FormRoot } from '@angular/forms/signals';
import { MatFormField, MatLabel } from '@angular/material/form-field';
import { MatInput } from '@angular/material/input';
import {
createDefaultRecipeFilterCriteria,
RecipeFilterCriteria,
Expand All @@ -8,33 +10,35 @@ import {
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
selector: 'wm-recipe-filter',
imports: [FormField, FormRoot],
imports: [FormField, FormRoot, MatFormField, MatInput, MatLabel],
template: `
<form [formRoot]="filterForm">
<input
[formField]="filterForm.keywords"
aria-label="Keywords"
placeholder="keywords"
type="text"
/>
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
<input
[formField]="filterForm.maxStepCount"
aria-label="Max Steps"
placeholder="max steps"
type="number"
/>
<form class="filter-form" [formRoot]="filterForm">
<mat-form-field>
<mat-label>Keywords</mat-label>
<input [formField]="filterForm.keywords" matInput type="text" />
</mat-form-field>
<mat-form-field>
<mat-label>Max Ingredients</mat-label>
<input
[formField]="filterForm.maxIngredientCount"
matInput
type="number"
/>
</mat-form-field>
<mat-form-field>
<mat-label>Max Steps</mat-label>
<input [formField]="filterForm.maxStepCount" matInput type="number" />
</mat-form-field>
</form>
`,
styles: `
:host {
text-align: center;
.filter-form {
display: flex;
flex-wrap: wrap;
gap: 1rem;
justify-content: center;

margin-top: 1rem;
}
`,
})
Expand Down
1 change: 0 additions & 1 deletion apps/404-recipe-filter-material-starter/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
Expand Down
50 changes: 27 additions & 23 deletions apps/501-recipe-preview-testronaut-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChangeDetectionStrategy, Component, model } from '@angular/core';
import { form, FormField, FormRoot } from '@angular/forms/signals';
import { MatFormField, MatLabel } from '@angular/material/form-field';
import { MatInput } from '@angular/material/input';
import {
createDefaultRecipeFilterCriteria,
RecipeFilterCriteria,
Expand All @@ -8,33 +10,35 @@ import {
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
selector: 'wm-recipe-filter',
imports: [FormField, FormRoot],
imports: [FormField, FormRoot, MatFormField, MatInput, MatLabel],
template: `
<form [formRoot]="filterForm">
<input
[formField]="filterForm.keywords"
aria-label="Keywords"
placeholder="keywords"
type="text"
/>
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
<input
[formField]="filterForm.maxStepCount"
aria-label="Max Steps"
placeholder="max steps"
type="number"
/>
<form class="filter-form" [formRoot]="filterForm">
<mat-form-field>
<mat-label>Keywords</mat-label>
<input [formField]="filterForm.keywords" matInput type="text" />
</mat-form-field>
<mat-form-field>
<mat-label>Max Ingredients</mat-label>
<input
[formField]="filterForm.maxIngredientCount"
matInput
type="number"
/>
</mat-form-field>
<mat-form-field>
<mat-label>Max Steps</mat-label>
<input [formField]="filterForm.maxStepCount" matInput type="number" />
</mat-form-field>
</form>
`,
styles: `
:host {
text-align: center;
.filter-form {
display: flex;
flex-wrap: wrap;
gap: 1rem;
justify-content: center;

margin-top: 1rem;
}
`,
})
Expand Down
50 changes: 27 additions & 23 deletions apps/501-recipe-preview-testronaut-starter/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChangeDetectionStrategy, Component, model } from '@angular/core';
import { form, FormField, FormRoot } from '@angular/forms/signals';
import { MatFormField, MatLabel } from '@angular/material/form-field';
import { MatInput } from '@angular/material/input';
import {
createDefaultRecipeFilterCriteria,
RecipeFilterCriteria,
Expand All @@ -8,33 +10,35 @@ import {
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
selector: 'wm-recipe-filter',
imports: [FormField, FormRoot],
imports: [FormField, FormRoot, MatFormField, MatInput, MatLabel],
template: `
<form [formRoot]="filterForm">
<input
[formField]="filterForm.keywords"
aria-label="Keywords"
placeholder="keywords"
type="text"
/>
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
<input
[formField]="filterForm.maxStepCount"
aria-label="Max Steps"
placeholder="max steps"
type="number"
/>
<form class="filter-form" [formRoot]="filterForm">
<mat-form-field>
<mat-label>Keywords</mat-label>
<input [formField]="filterForm.keywords" matInput type="text" />
</mat-form-field>
<mat-form-field>
<mat-label>Max Ingredients</mat-label>
<input
[formField]="filterForm.maxIngredientCount"
matInput
type="number"
/>
</mat-form-field>
<mat-form-field>
<mat-label>Max Steps</mat-label>
<input [formField]="filterForm.maxStepCount" matInput type="number" />
</mat-form-field>
</form>
`,
styles: `
:host {
text-align: center;
.filter-form {
display: flex;
flex-wrap: wrap;
gap: 1rem;
justify-content: center;

margin-top: 1rem;
}
`,
})
Expand Down
50 changes: 27 additions & 23 deletions apps/502-recipe-filter-testronaut-solution/src/app/recipe/recipe-filter.ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChangeDetectionStrategy, Component, model } from '@angular/core';
import { form, FormField, FormRoot } from '@angular/forms/signals';
import { MatFormField, MatLabel } from '@angular/material/form-field';
import { MatInput } from '@angular/material/input';
import {
createDefaultRecipeFilterCriteria,
RecipeFilterCriteria,
Expand All @@ -8,33 +10,35 @@ import {
@Component({
changeDetection: ChangeDetectionStrategy.OnPush,
selector: 'wm-recipe-filter',
imports: [FormField, FormRoot],
imports: [FormField, FormRoot, MatFormField, MatInput, MatLabel],
template: `
<form [formRoot]="filterForm">
<input
[formField]="filterForm.keywords"
aria-label="Keywords"
placeholder="keywords"
type="text"
/>
<input
[formField]="filterForm.maxIngredientCount"
aria-label="Max Ingredients"
formControlName="maxIngredientCount"
placeholder="max ingredients"
type="number"
/>
<input
[formField]="filterForm.maxStepCount"
aria-label="Max Steps"
placeholder="max steps"
type="number"
/>
<form class="filter-form" [formRoot]="filterForm">
<mat-form-field>
<mat-label>Keywords</mat-label>
<input [formField]="filterForm.keywords" matInput type="text" />
</mat-form-field>
<mat-form-field>
<mat-label>Max Ingredients</mat-label>
<input
[formField]="filterForm.maxIngredientCount"
matInput
type="number"
/>
</mat-form-field>
<mat-form-field>
<mat-label>Max Steps</mat-label>
<input [formField]="filterForm.maxStepCount" matInput type="number" />
</mat-form-field>
</form>
`,
styles: `
:host {
text-align: center;
.filter-form {
display: flex;
flex-wrap: wrap;
gap: 1rem;
justify-content: center;

margin-top: 1rem;
}
`,
})
Expand Down
Loading
Loading