Skip to content

fix: add missing picomatch dev dependency#7

Merged
0xFANGO merged 1 commit into
mainfrom
fix/add-missing-picomatch-dep
Apr 19, 2026
Merged

fix: add missing picomatch dev dependency#7
0xFANGO merged 1 commit into
mainfrom
fix/add-missing-picomatch-dep

Conversation

@0xFANGO
Copy link
Copy Markdown
Collaborator

@0xFANGO 0xFANGO commented Apr 19, 2026

Summary

  • vite-plus-core@0.1.18 requires picomatch at runtime but doesn't declare it in its own package.json
  • Under pnpm's strict node_modules isolation, this causes MODULE_NOT_FOUND on pnpm run build
  • Added picomatch as a dev dependency to work around the upstream omission

Test plan

  • pnpm run build succeeds

Note

Low Risk
Low risk: dependency-only change to resolve a build-time MODULE_NOT_FOUND under pnpm; no runtime/business logic code changes.

Overview
Fixes pnpm builds by explicitly adding picomatch@^4.0.4 as a dev dependency (and updating pnpm-lock.yaml) to satisfy an undeclared runtime requirement from vite-plus/vite-plus-core.

Reviewed by Cursor Bugbot for commit 9db1213. Configure here.

vite-plus-core requires picomatch at runtime but doesn't declare it
in its own package.json. pnpm's strict isolation causes MODULE_NOT_FOUND.
@0xFANGO 0xFANGO merged commit 65506e7 into main Apr 19, 2026
2 checks passed
@0xFANGO 0xFANGO deleted the fix/add-missing-picomatch-dep branch April 19, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant