fix: add missing picomatch dev dependency#7
Merged
Conversation
vite-plus-core requires picomatch at runtime but doesn't declare it in its own package.json. pnpm's strict isolation causes MODULE_NOT_FOUND.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite-plus-core@0.1.18requirespicomatchat runtime but doesn't declare it in its ownpackage.jsonnode_modulesisolation, this causesMODULE_NOT_FOUNDonpnpm run buildpicomatchas a dev dependency to work around the upstream omissionTest plan
pnpm run buildsucceedsNote
Low Risk
Low risk: dependency-only change to resolve a build-time
MODULE_NOT_FOUNDunder pnpm; no runtime/business logic code changes.Overview
Fixes pnpm builds by explicitly adding
picomatch@^4.0.4as a dev dependency (and updatingpnpm-lock.yaml) to satisfy an undeclared runtime requirement fromvite-plus/vite-plus-core.Reviewed by Cursor Bugbot for commit 9db1213. Configure here.