Fix CI: drop uv venv, setup-uv already creates the venv#2
Merged
Conversation
astral-sh/setup-uv@v5 with python-version creates a .venv automatically. Running uv venv again fails because it already exists. Just use uv pip install directly into the existing venv.
The loose >=23.12.0 constraint allowed CI to resolve an older Black version that formats code differently from local dev (25.x), causing spurious lint failures on content.py and server.py. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace Black with the uv-native Ruff (format + lint) and ty (type checking). Ruff auto-fixed import sorting, deprecated typing imports (Dict/List/Set -> builtins), unnecessary f-strings, and redundant open() mode args. Fixed one ty error (Optional parameter annotation). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the GitHub Actions CI workflow by removing the explicit creation of a virtual environment with
uv venvbefore installing dependencies. Instead, dependencies are now installed directly usinguv pip install, which streamlines the setup process in all relevant jobs.CI workflow simplification:
uv venvstep from the dependency installation commands in all jobs within.github/workflows/ci.yml, so dependencies are now installed directly withuv pip install. [1] [2] [3]Closes #1