fix(lenovo): send empty string for OldPassword in Bios.ChangePassword#1
Open
martinraumann wants to merge 1 commit into
Open
fix(lenovo): send empty string for OldPassword in Bios.ChangePassword#1martinraumann wants to merge 1 commit into
martinraumann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When
change_uefi_passwordis called with an emptycurrent_uefi_passwordon Lenovo hardware, the empty string was being serialized asnullin the JSON body sent to Bios.ChangePassword. Lenovo BMC rejectsnull— it requires an explicit empty string "".Fix
Override
change_uefi_passwordinsrc/lenovo.rsto build the Redfish request directly using aHashMap<String, String>instead of delegating to the standard implementation. This ensures that empty strings are serialized as "" in the JSON body, notnull.The fix uses String values throughout, so serde preserves empty strings as empty strings instead of converting them to null values.