Relocate shared engine source and expand protocol tests#24
Merged
Conversation
masarray
marked this pull request as ready for review
July 12, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete the remaining P2 architecture and coverage work by moving the shared IEC 61850 engine source physically under
src/ARSVIN.Engine, expanding deterministic regression tests, and raising enforced coverage baselines.Completed changes
Physical shared-engine ownership
src/ARSVIN/Engineintosrc/ARSVIN.Engineusinggit mv.ARSVIN.Engine.csproj.Compile Removeworkaround.ARSVIN.Engineassembly.Expanded deterministic regression tests
HexDumptests.Protocol fix discovered by the tests
smpCntwrap to every ASDU within the frame.3998, 3999, 0, 1rather than3998, 3999, 4000, 4001.Raised coverage gates
Validation completed
Validated private artifact:
ARSVIN-0.0.0-pr.72-windows-x64, digestsha256:62819271b6089a620050f9d54ae780050091bceb373a2867b6b3a6106af2d832.No public GitHub Release is created by this pull request.