Agent/sv research gate#26
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a68bade4a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ├── README.md | ||
| ├── source-register.md | ||
| ├── stream.scd | ||
| ├── capture.pcap |
There was a problem hiding this comment.
This evidence package now asks contributors to add capture.pcap, but the repo-wide .gitignore still ignores *.pcap and *.pcapng, so a normal git add samples/sv-evidence/<case-id>/ silently leaves the core capture out of the package. In the anonymized/synthetic evidence workflow described here, that makes the committed case incomplete unless contributors know to force-add the file or an exception is added for safe fixtures.
Useful? React with 👍 / 👎.
|
Superseded by #27 |
1 participant
Summary
Describe the change and why it is needed.
Type of change
Engineering notes
Explain the IEC 61850 / SV / SCL / COMTRADE / PTP behavior affected by this PR.
Safety impact
Test notes
dotnet build src/ARSVIN/ARSVIN.csproj -c Releasedotnet test tests/ARSVIN.Tests/ARSVIN.Tests.csproj -c ReleaseScreenshots / packet notes
Add screenshots or sanitized Wireshark notes when relevant.