Fix for instance type switching on older pg versions#22
Merged
coryodaniel merged 1 commit intomainfrom Mar 31, 2025
Merged
Conversation
AWS and/or Terraform have some interesting logic on the svls v2 config. This change + the existing local's defaults make it possible to switch instance types from serverless to serverful (:P) - this worked previously, but not on older versions of postgres that didnt support serverless, they would fail to provision due to a check for the serverless config block (which happens to be present).
Member
I believe the correct term is "servermore" |
chrisghill
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS and/or Terraform have some interesting logic on the svls v2 config.
This change + the existing local's defaults make it possible to switch instance types from serverless to serverful (:P) - this worked previously, but not on older versions of postgres that didnt support serverless, they would fail to provision due to a check for the serverless config block (which happens to be present).