Skip to content

Add backpressure handling for txChannel #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abolix wants to merge 2 commits into from
+34 −12
Closed

Add backpressure handling for txChannel #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7023e5
Add backpressure handling for txChannel
abolix Mar 31, 2026
81236d2
Enhance dispatch loop with context and idle timer handling
abolix Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 34 additions & 12 deletions internal/client/dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,25 @@ dispatchLoop:
}

if !c.txChannelHasCapacity(len(conns)) {
if !waitForWork() {
select {
case <-ctx.Done():
return
case <-c.txSpaceSignal:
if !c.txChannelHasCapacity(len(conns)) {
continue dispatchLoop
}
case <-idleTimer.C:
if !idleTimer.Stop() {
select {
case <-idleTimer.C:
default:
}
}
idleTimer.Reset(idlePoll)
if !c.txChannelHasCapacity(len(conns)) {
continue dispatchLoop
}
}
continue dispatchLoop
}

var item *clientStreamTXPacket
Expand Down Expand Up @@ -375,7 +390,8 @@ dispatchLoop:
}

packetByDomain := make(map[string][]byte, len(conns))
// var isLogged bool = false
pendingPkts := make([]asyncPacket, 0, len(conns))

for _, conn := range conns {
domain := conn.Domain
if domain == "" {
Expand All @@ -394,19 +410,25 @@ dispatchLoop:
pkt := finalPacket
pkt.conn = conn
pkt.payload = dnsPacket
pendingPkts = append(pendingPkts, pkt)
}

if !c.txChannelHasCapacity(len(pendingPkts)) {
select {
case c.txSignal <- struct{}{}:
default:
}
if !wasPacked && selected != nil {
selected.ReleaseTXPacket(item)
}
continue dispatchLoop
}

for _, pkt := range pendingPkts {
select {
case c.txChannel <- pkt:
// if !isLogged && pkt.packetType != Enums.PACKET_PING {
// packedSummary := ""
// if opts.PacketType == Enums.PACKET_PACKED_CONTROL_BLOCKS {
// packedSummary = " | " + VpnProto.DescribePackedControlBlocks(opts.Payload, 4)
// }
// c.logOutboundPacket(opts.PacketType, opts.SessionID, len(opts.Payload), opts.StreamID, opts.SequenceNum, opts.FragmentID, opts.TotalFragments, packedSummary)
// }
// isLogged = true
default:
c.log.Warnf("TX channel filled before enqueue completed | Packet: %s | Stream: %d", Enums.PacketTypeName(finalPacket.packetType), selectedStreamID)
c.log.Warnf("TX channel race: packet dropped | Packet: %s | Stream: %d", Enums.PacketTypeName(finalPacket.packetType), selectedStreamID)
}
}

Expand Down
Loading