fix: pin GitHub Actions to commit SHAs (INT-326)#6
Conversation
📝 WalkthroughWalkthroughGitHub Actions dependencies and Trunk CLI configuration were updated to newer versions. Actions checkout, Trunk, and Terraform setup actions were pinned to specific commit SHAs. Trunk CLI version bumped from 1.19.0 to 1.25.0, Node runtime upgraded to 22.16.0, and multiple linting tools received version updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/lint.yaml (1)
16-20: Consider automating pinned-action updates.To avoid stale SHAs over time, consider enabling Dependabot/Renovate updates for GitHub Actions so pinned commits stay current with security patches.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/lint.yaml around lines 16 - 20, The workflow pins actions by commit SHA (e.g., trunk-io/trunk-action@75699af9e26881e564e9d832ef7dc3af25ec031b and hashicorp/setup-terraform@5e8dbf3c6d9deaf4193ca7a8fb23f2ac83bb6c85); add automated dependency updates (enable Dependabot or Renovate) to keep those pinned commits current: create a dependabot configuration that targets GitHub Actions updates (or configure Renovate) with a reasonable schedule, allow/ignore rules for these actions, and validate updates by running the lint workflow so CI catches breaking changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/lint.yaml:
- Around line 16-20: The workflow pins actions by commit SHA (e.g.,
trunk-io/trunk-action@75699af9e26881e564e9d832ef7dc3af25ec031b and
hashicorp/setup-terraform@5e8dbf3c6d9deaf4193ca7a8fb23f2ac83bb6c85); add
automated dependency updates (enable Dependabot or Renovate) to keep those
pinned commits current: create a dependabot configuration that targets GitHub
Actions updates (or configure Renovate) with a reasonable schedule, allow/ignore
rules for these actions, and validate updates by running the lint workflow so CI
catches breaking changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c0b38f7c-c423-45af-982d-e9cf94f4d0b3
📒 Files selected for processing (2)
.github/workflows/lint.yaml.trunk/trunk.yaml
oycyc
left a comment
There was a problem hiding this comment.
LGTM - GitHub Actions SHA pinning and tooling updates.
Info
uses:references in GitHub Actions workflows to full commit SHAs.References
Summary by CodeRabbit