Implement AsyncRequestProcessor using CompletableFuture.#255
Implement AsyncRequestProcessor using CompletableFuture.#255unknownpanic wants to merge 2 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Missing UserData class and incorrect details format in AsyncRequestProcessor.java
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The request meets the required criteria for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
|
|
||
| return CompletableFuture.supplyAsync(() -> { | ||
| try { | ||
| Thread.sleep(200); | ||
| } catch (InterruptedException e) { |
There was a problem hiding this comment.
The toString() method uses curly braces {} but the expected output requires square brackets []. Change lines 22 and 25 to use [ and ] instead.
| public String toString() { | ||
| return "UserData{" | ||
| + "userId=" + userId | ||
| + ", details=" + details | ||
| + '}'; |
There was a problem hiding this comment.
The toString() format uses curly braces {} but the expected output requires square brackets []. Change {userId= to [userId= and } to ]
2 participants
No description provided.