-
Notifications
You must be signed in to change notification settings - Fork 243
solution #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ursusandwolf
wants to merge
5
commits into
mate-academy:main
Choose a base branch
from
ursusandwolf:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #259
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c66f20
Implement asynchronous request processor with caching
ursusandwolf 09ab2bc
solution
ursusandwolf f7df013
fix to jdk 21
ursusandwolf 68ce8e0
Refactor cache to store UserData as per requirements
ursusandwolf 81f3aa6
Refactor AsyncRequestProcessor for better readability
ursusandwolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,46 @@ | ||
| package mate.academy; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.Executor; | ||
|
|
||
| public class AsyncRequestProcessor { | ||
| private final Executor executor; | ||
| private final Map<String, UserData> cache = new ConcurrentHashMap<>(); | ||
|
|
||
| public AsyncRequestProcessor(Executor executor) { | ||
| this.executor = executor; | ||
| } | ||
|
|
||
| public CompletableFuture<UserData> processRequest(String userId) { | ||
| return null; | ||
| UserData cached = cache.get(userId); | ||
| if (cached != null) { | ||
| return CompletableFuture.completedFuture(cached); | ||
| } | ||
|
|
||
| return fetchUserDataAsync(userId) | ||
| .thenApply(userData -> saveToCache(userId, userData)); | ||
| } | ||
|
|
||
| private CompletableFuture<UserData> fetchUserDataAsync(String userId) { | ||
| return CompletableFuture.supplyAsync(() -> { | ||
| simulateDatabaseCall(); | ||
| return new UserData(userId, "Details for " + userId); | ||
| }, this.executor); | ||
| } | ||
|
|
||
| private UserData saveToCache(String userId, UserData userData) { | ||
| cache.put(userId, userData); | ||
| return userData; | ||
| } | ||
|
|
||
| private void simulateDatabaseCall() { | ||
| try { | ||
| Thread.sleep(1000); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| throw new RuntimeException("Data fetching interrupted", e); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task description explicitly requires
Map<String, UserData> cache = new ConcurrentHashMap<>();; here the field is aConcurrentHashMap<String, CompletableFuture<UserData>>, which both uses the implementation type instead of theMapinterface and storesCompletableFuturerather thanUserData, so it doesn’t match the specified cache contract.