Skip to content

add solution#167

Open
Victoria-Moiseienko wants to merge 2 commits into
mate-academy:masterfrom
Victoria-Moiseienko:homework1-3
Open

add solution#167
Victoria-Moiseienko wants to merge 2 commits into
mate-academy:masterfrom
Victoria-Moiseienko:homework1-3

Conversation

@Victoria-Moiseienko

Copy link
Copy Markdown

No description provided.

Comment thread src/main/java/core/basesyntax/BinaryString.java
Comment on lines +13 to +20

StringBuilder mirrorString = new StringBuilder();

while (value >= 1) {
mirrorString.append(value % 2);
value = value >> 1;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to separate your code inside the method with empty lines, it's readable enough without it, and you make it longer

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants