hw-1.2#169
Open
mikhail771 wants to merge 3 commits into
Open
Conversation
| || ((a && d) && (!c && !b)) | ||
| || ((b && c) && (!a && !d)) | ||
| || ((b && d) && (!c && !a)) | ||
| || ((c && d) && (!a && !b))) ? true : false; |
There was a problem hiding this comment.
ternary operator is redundant here, try to remove it and check result
| */ | ||
| public boolean booleanExpression(boolean a, boolean b, boolean c, boolean d) { | ||
| return false; | ||
| return (((a && b) && (!c && !d)) |
There was a problem hiding this comment.
try to make this shorter with ^ (XOR) operator
Comment on lines
+17
to
+22
| return (((a ^ b) && (c ^ d)) | ||
| || ((a ^ c) && (b ^ d)) | ||
| || ((a ^ d) && (c ^ b)) | ||
| || ((b ^ c) && (a ^ d)) | ||
| || ((b ^ d) && (c ^ a)) | ||
| || ((c ^ d) && (a ^ b))); |
There was a problem hiding this comment.
you've got some redundant check here:
Suggested change
| return (((a ^ b) && (c ^ d)) | |
| || ((a ^ c) && (b ^ d)) | |
| || ((a ^ d) && (c ^ b)) | |
| || ((b ^ c) && (a ^ d)) | |
| || ((b ^ d) && (c ^ a)) | |
| || ((c ^ d) && (a ^ b))); | |
| return (a ^ b) && (c ^ d) || (a ^ c) && (b ^ d); |
RomanDubovskyi
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.