Skip to content

Homework #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhii-hl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Homework #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f01bb
Added logs
serhii-hl Jun 19, 2025
b950430
Added logs
serhii-hl Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,5 @@ Fix the solution to remove the race condition between the threads.
Each thread should take the value that was decremented by the previous thread, and the logs should be consistent.
Let's allow only one thread to execute the meaningful part of code at a time.

Note that you should push the file with logs to your PR, so please, do not add it to `.gitignore`.
Note that you should push the file with logs to your PR, so please, do not add it o `.gitignore`.
You may probably need to use the absolute path to the log file in `log4j2.xml`.
40 changes: 40 additions & 0 deletions logs/app.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 1, counter value 20
INFO core.basesyntax.Counter:19 After decrementing, Thread # 1, counter value 19
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 20, counter value 19
INFO core.basesyntax.Counter:19 After decrementing, Thread # 20, counter value 18
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 19, counter value 18
INFO core.basesyntax.Counter:19 After decrementing, Thread # 19, counter value 17
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 18, counter value 17
INFO core.basesyntax.Counter:19 After decrementing, Thread # 18, counter value 16
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 17, counter value 16
INFO core.basesyntax.Counter:19 After decrementing, Thread # 17, counter value 15
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 16, counter value 15
INFO core.basesyntax.Counter:19 After decrementing, Thread # 16, counter value 14
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 15, counter value 14
INFO core.basesyntax.Counter:19 After decrementing, Thread # 15, counter value 13
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 14, counter value 13
INFO core.basesyntax.Counter:19 After decrementing, Thread # 14, counter value 12
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 11, counter value 12
INFO core.basesyntax.Counter:19 After decrementing, Thread # 11, counter value 11
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 10, counter value 11
INFO core.basesyntax.Counter:19 After decrementing, Thread # 10, counter value 10
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 13, counter value 10
INFO core.basesyntax.Counter:19 After decrementing, Thread # 13, counter value 9
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 12, counter value 9
INFO core.basesyntax.Counter:19 After decrementing, Thread # 12, counter value 8
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 9, counter value 8
INFO core.basesyntax.Counter:19 After decrementing, Thread # 9, counter value 7
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 8, counter value 7
INFO core.basesyntax.Counter:19 After decrementing, Thread # 8, counter value 6
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 7, counter value 6
INFO core.basesyntax.Counter:19 After decrementing, Thread # 7, counter value 5
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 6, counter value 5
INFO core.basesyntax.Counter:19 After decrementing, Thread # 6, counter value 4
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 5, counter value 4
INFO core.basesyntax.Counter:19 After decrementing, Thread # 5, counter value 3
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 4, counter value 3
INFO core.basesyntax.Counter:19 After decrementing, Thread # 4, counter value 2
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 3, counter value 2
INFO core.basesyntax.Counter:19 After decrementing, Thread # 3, counter value 1
INFO core.basesyntax.Counter:16 Before decrementing, Thread # 2, counter value 1
INFO core.basesyntax.Counter:19 After decrementing, Thread # 2, counter value 0
2 changes: 1 addition & 1 deletion src/main/java/core/basesyntax/Counter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public Counter(int value) {
this.value = value;
}

public void decreaseValue() {
public synchronized void decreaseValue() {
logger.info(String.format(MESSAGE,
"Before decrementing", Thread.currentThread().getName(), value));
value--;
Expand Down