Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,30 @@
package practice;

public class CandidateValidator {
import java.util.function.Predicate;
import java.util.stream.Stream;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
private static final String REQUIRED_NATIONALITY = "Ukrainian";
private static final String HYPHEN = "-";
private static final int MIN_CANDIDATE_AGE = 35;
private static final int MIN_YEARS_IN_UKRAINE = 10;

//write your code here
@Override
public boolean test(Candidate candidate) {
if (candidate == null) {
Comment thread
ReduxR marked this conversation as resolved.
return false;
}

int yearsInUkraine = Stream.of(candidate.getPeriodsInUkr())
.map(period -> period.split(HYPHEN))
.mapToInt(arr -> Integer.parseInt(arr[1]) - Integer.parseInt(arr[0]))
.sum();

return candidate.getAge() >= MIN_CANDIDATE_AGE
&& candidate.isAllowedToVote()
&& REQUIRED_NATIONALITY.equals(candidate.getNationality())
&& yearsInUkraine >= MIN_YEARS_IN_UKRAINE;
}
}
48 changes: 41 additions & 7 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
private static final String COMMA = ",";

/**
* Given list of strings where each element contains 1+ numbers:
* input = {"5,30,100", "0,22,7", ...}
Expand All @@ -14,7 +19,13 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()
.flatMap(n -> Arrays.stream(n.split(COMMA)))
.map(num -> Integer.valueOf(num.trim()))
.filter(num -> num % 2 == 0)
.min(Integer::compareTo)
.orElseThrow(() ->
new RuntimeException("Can't get min value from list: " + numbers));
}

/**
Expand All @@ -23,7 +34,11 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
return IntStream.range(0, numbers.size())
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i))
.filter(n -> n % 2 != 0)
.average()
.orElseThrow(NoSuchElementException::new);
}

/**
Expand All @@ -35,7 +50,11 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(person -> person.getAge() >= fromAge
&& person.getAge() <= toAge
&& person.getSex().equals(Person.Sex.MAN))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While .equals() works for enums, the task checklist suggests that comparing them with == is generally better for performance and it's null-safe. For example: person.getSex() == Person.Sex.MAN.

.toList();
}

/**
Expand All @@ -50,7 +69,11 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream()
.filter(person -> person.getSex().equals(Person.Sex.MAN)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the checklist, using == is often a better way to compare enum values.

? person.getAge() >= fromAge && person.getAge() <= maleToAge
: person.getAge() >= fromAge && person.getAge() <= femaleToAge)
.toList();
}

/**
Expand All @@ -59,7 +82,13 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(person -> person.getSex().equals(Person.Sex.WOMAN)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted before, the project checklist recommends using == to compare enum values.

&& person.getAge() >= femaleAge)
.flatMap(person -> person.getCats().stream())
.map(Cat::getName)
.toList();

}

/**
Expand All @@ -75,6 +104,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
CandidateValidator candidateValidator = new CandidateValidator();
return candidates.stream()
.filter(candidateValidator)
.map(Candidate::getName)
.sorted()
.toList();
}
}
Loading