Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
public static final int MIN_AGE = 35;
public static final int MIN_PERIOD_IN_UKRAINE = 10;
public static final String NATIONALITY = "Ukrainian";

@Override
public boolean test(Candidate c) {
return c.getAge() >= MIN_AGE
&& c.isAllowedToVote()
&& NATIONALITY.equals(c.getNationality())
&& getYearsInUkraine(c.getPeriodsInUkr()) >= MIN_PERIOD_IN_UKRAINE;
}

private int getYearsInUkraine(String period) {
String[] parts = period.split("-");
int start = Integer.parseInt(parts[0]);
int end = Integer.parseInt(parts[1]);
return end - start;
}
}
48 changes: 41 additions & 7 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
Expand All @@ -14,7 +18,14 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()
.flatMap(s -> Arrays.stream(s.split(",")))
.mapToInt(Integer::parseInt)
.filter(n -> (n % 2) == 0)
.min()
.orElseThrow(() -> new RuntimeException(
"Can't get min value from list: " + numbers
));
}

/**
Expand All @@ -23,7 +34,11 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
return IntStream.range(0, numbers.size())
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i))
.filter(n -> n % 2 != 0)
.average()
.orElseThrow(NoSuchElementException::new);
}

/**
Expand All @@ -35,7 +50,10 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex() == Person.Sex.MAN)
.filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge)
Comment on lines +54 to +55

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works, you can combine these two filter operations into a single one for better readability and to use a minimum number of stream operations, as suggested in the checklist. You can chain the conditions using &&.

.collect(Collectors.toList());
}

/**
Expand All @@ -50,7 +68,14 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> {
int age = p.getAge();
return p.getSex() == Person.Sex.MAN
? age >= fromAge && age <= maleToAge
: age >= fromAge && age <= femaleToAge;
})
.collect(Collectors.toList());
}

/**
Expand All @@ -59,7 +84,12 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex() == Person.Sex.WOMAN)
.filter(p -> p.getAge() >= femaleAge)
Comment on lines +88 to +89

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the selectMenByAge method, you can combine these two filter conditions into a single operation to make the stream pipeline more concise. This adheres to the guideline of using a minimum number of stream operations.

.flatMap(p -> p.getCats().stream())
.map(Cat::getName)
.collect(Collectors.toList());
}

/**
Expand All @@ -75,6 +105,10 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
return candidates.stream()
.filter(new CandidateValidator())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While CandidateValidator is used correctly here, its implementation still contains a hardcoded string "Ukrainian". According to checklist item #6, magic strings should also be constants. Please define it as a private static final constant, similar to how you handled MIN_AGE.

.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());
}
}
Loading