-
Notifications
You must be signed in to change notification settings - Fork 1.3k
completed all tasks #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
completed all tasks #1396
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,31 @@ | ||
| package practice; | ||
|
|
||
| public class CandidateValidator { | ||
| //write your code here | ||
| import java.util.function.Predicate; | ||
| import model.Candidate; | ||
|
|
||
| public class CandidateValidator implements Predicate<Candidate> { | ||
| private static final String NATIONALITY = "Ukrainian"; | ||
| private static final int REQUIRED_YEARS_IN_UKRAINE = 10; | ||
| private static final int MIN_AGE = 35; | ||
|
|
||
| @Override | ||
| public boolean test(Candidate candidate) { | ||
| if (candidate.getAge() < MIN_AGE) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!candidate.isAllowedToVote()) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!NATIONALITY.equals(candidate.getNationality())) { | ||
| return false; | ||
| } | ||
|
|
||
| String[] years = candidate.getPeriodsInUkr().split("-"); | ||
| int firstYear = Integer.parseInt(years[0]); | ||
| int lastYear = Integer.parseInt(years[1]); | ||
|
|
||
| return (lastYear - firstYear) >= REQUIRED_YEARS_IN_UKRAINE; | ||
| } | ||
| } | ||
|
Comment on lines
+30
to
31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're splitting tokens and immediately calling Integer.parseInt. The task example shows inputs like |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,13 @@ | ||
| package practice; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.NoSuchElementException; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
| import model.Candidate; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checklist requires using constants instead of magic numbers/strings in CandidateValidator. Extract literals like 35 (min age), 10 (required years in Ukraine) and "Ukrainian" into named constants in this class for readability and maintainability. |
||
| import model.Cat; | ||
| import model.Person; | ||
|
|
||
| public class StreamPractice { | ||
|
|
@@ -14,7 +19,16 @@ public class StreamPractice { | |
| * "Can't get min value from list: < Here is our input 'numbers' >" | ||
| */ | ||
| public int findMinEvenNumber(List<String> numbers) { | ||
| return 0; | ||
|
|
||
| return numbers.stream() | ||
| .flatMap(s -> Arrays.stream(s.split(","))) | ||
| .map(String::trim) | ||
| .map(Integer::parseInt) | ||
| .filter(n -> n % 2 == 0) | ||
| .min(Integer::compareTo) | ||
| .orElseThrow(() -> new RuntimeException( | ||
| "Can't get min value from list: " + numbers | ||
| )); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -23,9 +37,14 @@ public int findMinEvenNumber(List<String> numbers) { | |
| * But before that subtract 1 from each element on an odd position (having the odd index). | ||
| */ | ||
| public Double getOddNumsAverage(List<Integer> numbers) { | ||
| return 0D; | ||
| return IntStream.range(0, numbers.size()) | ||
| .map(i -> i % 2 != 0 | ||
| ? numbers.get(i) - 1 | ||
| : numbers.get(i)) | ||
| .filter(n -> n % 2 != 0) | ||
| .average() | ||
| .orElseThrow(NoSuchElementException::new); | ||
| } | ||
|
|
||
| /** | ||
| * Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||
| * for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||
|
|
@@ -34,8 +53,12 @@ public Double getOddNumsAverage(List<Integer> numbers) { | |
| * <p> | ||
| * Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||
| */ | ||
|
|
||
| public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex() == Person.Sex.MAN) | ||
| .filter(person -> person.getAge() >= fromAge && person.getAge() <= toAge) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -50,7 +73,13 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA | |
| */ | ||
| public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||
| int maleToAge, List<Person> peopleList) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> (p.getSex() == Person.Sex.WOMAN | ||
| && p.getAge() >= fromAge | ||
| && p.getAge() <= femaleToAge) | ||
| || (p.getSex() == Person.Sex.MAN | ||
| && p.getAge() >= fromAge && p.getAge() <= maleToAge)) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -59,7 +88,13 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | |
| * return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||
| */ | ||
| public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(person -> person.getSex() == Person.Sex.WOMAN | ||
| && person.getAge() >= femaleAge) | ||
| .map(Person::getCats) | ||
| .flatMap(Collection::stream) | ||
| .map(Cat::getName) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -75,6 +110,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | |
| * parametrized with Candidate in CandidateValidator. | ||
| */ | ||
| public List<String> validateCandidates(List<Candidate> candidates) { | ||
| return Collections.emptyList(); | ||
|
|
||
| return candidates.stream() | ||
| .filter(new CandidateValidator()) | ||
| .map(Candidate::getName) | ||
| .sorted() | ||
| .toList(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In findMinEvenNumber you call Arrays.stream(s.trim().split(",")) and then Integer.parseInt on each token. Trimming the whole input string doesn't remove leading spaces inside tokens (e.g. "0, 22, 7" → tokens like " 22"). This will cause NumberFormatException. Trim each token before parsing (for example: .flatMap(s -> Arrays.stream(s.split(","))).map(String::trim).map(Integer::parseInt) ).