done#1398
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation has three critical checklist violations that must be fixed before approval: 1. Exception message format is incorrect — The checklist specifies the exact message as "Can't get min value from list: " + numbers (note the space before numbers). Your current implementation is missing this space, which will cause test failures. 2. Enum comparison using == instead of equals() — Tasks 3 and 4 use p.getSex() == Person.Sex.MAN. The checklist explicitly states to use equals() for comparing Enum values. Change to p.getSex().equals(Person.Sex.MAN). 3. Inclusive age comparison incorrect — Task 5 uses p.getAge() > femaleAge but the requirement clearly states "from femaleAge years old inclusively". This should be p.getAge() >= femaleAge. A minor improvement to consider: in CandidateValidator, the split(",") method doesn't handle whitespace, so inputs like "0, 22, 7" will fail with NumberFormatException. Consider using split(",\s*") or adding .map(String::trim). The core logic and stream usage are solid — these fixes are straightforward checklist compliance issues.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| .orElseThrow(() -> new RuntimeException( | ||
| "Can't get min value from list:" + numbers)); |
There was a problem hiding this comment.
Missing space in exception message. Checklist requires: "Can't get min value from list: " + numbers (with space before 'numbers')
| return peopleList.stream() | ||
| .filter(p -> p.getSex() == Person.Sex.MAN |
There was a problem hiding this comment.
Checklist states: 'Pay attention to what is a better way to compare Enum values: equals() vs ==?' Use equals() instead of == for Sex enum comparison.
| .filter(p -> p.getAge() >= fromAge) | ||
| .filter(p -> (p.getSex() == Person.Sex.MAN && p.getAge() <= maleToAge) | ||
| || (p.getSex() == Person.Sex.WOMAN && p.getAge() <= femaleToAge)) |
There was a problem hiding this comment.
Use equals() instead of == for Sex enum comparison.
| public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex() == Person.Sex.WOMAN && p.getAge() > femaleAge) |
There was a problem hiding this comment.
Task description says 'from femaleAge years old inclusively' but code uses > instead of >=. Should be p.getAge() >= femaleAge
| && candidate.getNationality().equals(REQUIRED_NATIONALITY) | ||
| && yearInUkraine >= MIN_YEARS_IN_UKRAINE; |
There was a problem hiding this comment.
The split(",") doesn't handle whitespace. Input like "0, 22, 7" will produce strings with leading spaces that Integer::parseInt can't handle. Consider using split(",\s*") or adding .map(String::trim).
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All critical checklist violations from the previous review have been successfully resolved: enum comparisons now properly use ".equals()" instead of "==", inclusive age ranges correctly use ">=" operators, and exception messages include the required spacing. The implementation demonstrates solid understanding of Stream API with proper predicate composition, correct handling of edge cases like empty streams, and clean separation of concerns with constants in CandidateValidator. All six tasks pass their requirements, and the code follows the specified checklist guidelines throughout. Great work on addressing all the feedback and improving your implementation!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.