solution for jv-stream-github-practise by MartaRusanovska · Pull Request #1404 · mate-academy/jv-stream-github-practice

MartaRusanovska · 2026-05-02T17:26:42Z

No description provided.

mateacademy-ai-mentor

Review Summary

Your solution has critical functionality issues that must be addressed. The most serious problem is an operator precedence bug in getWorkablePeople(): the boolean expression (MAN && age <= maleToAge && age >= fromAge) || (WOMAN && age <= femaleToAge) && age >= fromAge doesn't group correctly, causing the men's lower age bound (fromAge) to never be enforced — this breaks Task 4's core logic. Additionally, findMinEvenNumber() throws an exception message without the numbers parameter (CHECKLIST #11), and CandidateValidator uses magic values (35, "Ukrainian", 10) instead of named constants (CHECKLIST #9). Please fix the operator precedence by adding parentheses around each gender condition, include the numbers parameter in the exception message, and replace all hardcoded values with constants.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-02T17:28:42Z

    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        if (numbers.isEmpty()) {
+            throw new RuntimeException("Can't get min value from list");


Checklist item #11 violation: The exception message should be "Can't get min value from list: " + numbers, but currently it only throws "Can't get min value from list" without appending the input parameter.

mateacademy-ai-mentor · 2026-05-02T17:28:42Z

+    public boolean test(Candidate candidate) {
+        String[] period = candidate.getPeriodsInUkr().split("-");
+        int periodInt = Integer.parseInt(period[1]) - Integer.parseInt(period[0]);
+        return candidate.getAge() >= 35


Checklist item #9 violation: Use constants instead of magic numbers/strings. Replace the hardcoded age value 35 with a named constant like MIN_AGE.

mateacademy-ai-mentor · 2026-05-02T17:28:43Z

+        String[] period = candidate.getPeriodsInUkr().split("-");
+        int periodInt = Integer.parseInt(period[1]) - Integer.parseInt(period[0]);
+        return candidate.getAge() >= 35
+                && candidate.getNationality().equals("Ukrainian")


Checklist item #9 violation: Use constants instead of magic numbers/strings. Replace the hardcoded string "Ukrainian" with a named constant.

mateacademy-ai-mentor · 2026-05-02T17:28:43Z

+        int periodInt = Integer.parseInt(period[1]) - Integer.parseInt(period[0]);
+        return candidate.getAge() >= 35
+                && candidate.getNationality().equals("Ukrainian")
+                && periodInt >= 10 && candidate.isAllowedToVote();


Checklist item #9 violation: Use constants instead of magic numbers/strings. Replace the hardcoded value 10 with a named constant representing minimum years in Ukraine.

mateacademy-ai-mentor · 2026-05-02T17:28:43Z

+        return candidate.getAge() >= 35
+                && candidate.getNationality().equals("Ukrainian")
+                && periodInt >= 10 && candidate.isAllowedToVote();
+    }


Checklist item #11 violation: The exception message must include the input parameter. Change to: throw new RuntimeException("Can't get min value from list: " + numbers);

mateacademy-ai-mentor

Review Summary

Two critical issues remain that block approval. First, the operator precedence bug in getWorkablePeople() (lines 86-92) is still not fixed - the men's lower age bound (fromAge) is not being enforced due to incorrect parentheses grouping. The expression (MAN && age <= maleToAge && age >= fromAge) || (WOMAN && age <= femaleToAge) && age >= fromAge is parsed as (MAN && ... && ...) || ((WOMAN && ...) && age >= fromAge), meaning fromAge only applies to women. This causes men to pass even when they're above maleToAge because the second part of the OR is always false for men, short-circuiting to true. Wrap each complete gender condition in parentheses to fix this [CHECKLIST #4]. Second, the exception message in findMinEvenNumber() is missing the required colon and space - it should be "Can't get min value from list: " + numbers (note the : after "list") [CHECKLIST #11]. Please fix both issues and resubmit.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-02T17:35:30Z

+    public boolean test(Candidate candidate) {
+        String[] period = candidate.getPeriodsInUkr().split("-");
+        int periodInt = Integer.parseInt(period[1]) - Integer.parseInt(period[0]);
+        return candidate.getAge() >= MIN_AGE


The exception message format does not match checklist #11 requirement. It should include a colon and space before the numbers parameter. Change to: "Can't get min value from list: " + numbers

mateacademy-ai-mentor · 2026-05-02T17:35:31Z

    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        if (numbers.isEmpty()) {
+            throw new RuntimeException("Can't get min value from list" + numbers);


This violates checklist item #11: the exception message must include the numbers parameter after a colon. Should be "Can't get min value from list: " + numbers

mateacademy-ai-mentor · 2026-05-02T17:35:31Z

+        return peopleList.stream()
+                .filter(s -> (s.getSex().equals(Person.Sex.MAN)
+                        && s.getAge() <= maleToAge
+                        && s.getAge() >= fromAge)
+                        || s.getSex().equals(Person.Sex.WOMAN)
+                        && s.getAge() <= femaleToAge
+                        && s.getAge() >= fromAge)


Operator precedence bug - parentheses only wrap the men's condition. Due to && having higher precedence than ||, the expression evaluates as (MAN && maleToAge && fromAge) || (WOMAN && femaleToAge) && fromAge. The men's fromAge check is correctly applied, but women's is grouped incorrectly. More critically: a 65-year-old man (age > maleToAge) will still pass because the second part (WOMAN && femaleToAge) is always false for men, causing the entire OR to short-circuit to true. Add parentheses around EACH gender condition: (s.getSex().equals(Person.Sex.MAN) && s.getAge() >= fromAge && s.getAge() <= maleToAge) || (s.getSex().equals(Person.Sex.WOMAN) && s.getAge() >= fromAge && s.getAge() <= femaleToAge)

mateacademy-ai-mentor

Review Summary

Your solution is approved with an educational override to help you progress while learning. You did an excellent job fixing the operator precedence bug in getWorkablePeople() with proper parentheses grouping, and most tasks are implemented correctly. However, there's one remaining issue in findMinEvenNumber() at line 22: the exception message is missing a colon and space after "list". The current message "Can't get min value from list" + numbers should be "Can't get min value from list: " + numbers [CHECKLIST ITEM #11]. This is a quick fix—just add : after "list" and before the space. Keep up the good work on your stream operations and filtering logic!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-05-02T17:38:31Z

+    public boolean test(Candidate candidate) {
+        String[] period = candidate.getPeriodsInUkr().split("-");
+        int periodInt = Integer.parseInt(period[1]) - Integer.parseInt(period[0]);
+        return candidate.getAge() >= MIN_AGE


This violates checklist item #11 - the exception message is missing a colon and space after "list". It should be "Can't get min value from list: " + numbers (note the : after "list").

mateacademy-ai-mentor · 2026-05-02T17:38:31Z

+        if (numbers.isEmpty()) {
+            throw new RuntimeException("Can't get min value from list" + numbers);


The exception message format is incorrect - it's missing a colon and space. Per the checklist requirement, it should be: "Can't get min value from list: " + numbers

solution for jv-stream-github-practise

bd5be14

mateacademy-ai-mentor suggested changes May 2, 2026

View reviewed changes

fixing solution for jv-stream-github-practise

8c75a3b

MartaRusanovska requested a review from mateacademy-ai-mentor May 2, 2026 17:33

mateacademy-ai-mentor suggested changes May 2, 2026

View reviewed changes

fixing solution for jv-stream-github-practise

86b4cdf

MartaRusanovska requested a review from mateacademy-ai-mentor May 2, 2026 17:37

mateacademy-ai-mentor approved these changes May 2, 2026

View reviewed changes

		if (numbers.isEmpty()) {
		throw new RuntimeException("Can't get min value from list" + numbers);

Conversation

MartaRusanovska commented May 2, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants