-
Notifications
You must be signed in to change notification settings - Fork 1.3k
did #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
did #1408
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| package practice; | ||
|
|
||
| public class CandidateValidator { | ||
| //write your code here | ||
| import java.util.function.Predicate; | ||
| import model.Candidate; | ||
|
|
||
| public class CandidateValidator implements Predicate<Candidate> { | ||
|
|
||
| private static final int MIN_AGE = 35; | ||
| private static final int MIN_YEAR = 10; | ||
|
|
||
| @Override | ||
| public boolean test(Candidate candidate) { | ||
| String[] years = candidate.getPeriodsInUkr().split("-"); | ||
| int yearsInUkr = Integer.parseInt(years[1]) - Integer.parseInt(years[0]); | ||
|
|
||
| return candidate.getAge() >= MIN_AGE | ||
| && candidate.isAllowedToVote() | ||
| && "Ukrainian".equals(candidate.getNationality()) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The string "Ukrainian" should be extracted as a constant named |
||
| && yearsInUkr >= MIN_YEAR; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,13 @@ | ||
| package practice; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Arrays; | ||
| import java.util.Comparator; | ||
| import java.util.List; | ||
| import java.util.NoSuchElementException; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
| import model.Candidate; | ||
|
Comment on lines
+8
to
9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checklist item #6 violation: The constant should be named |
||
| import model.Cat; | ||
| import model.Person; | ||
|
|
||
| public class StreamPractice { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checklist item #5 violation: Use constants instead of magic numbers. Define private static final int MIN_AGE = 35; and use it here |
||
|
|
@@ -14,7 +19,14 @@ public class StreamPractice { | |
| * "Can't get min value from list: < Here is our input 'numbers' >" | ||
| */ | ||
| public int findMinEvenNumber(List<String> numbers) { | ||
| return 0; | ||
| return numbers.stream() | ||
| .flatMap(s -> Arrays.stream(s.split(","))) | ||
| .map(String::trim) | ||
| .map(Integer::parseInt) | ||
| .filter(n -> n % 2 == 0) | ||
| .min(Comparator.naturalOrder()) | ||
| .orElseThrow(() -> new RuntimeException("Can't get min value from list: " | ||
| + numbers)); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -23,7 +35,11 @@ public int findMinEvenNumber(List<String> numbers) { | |
| * But before that subtract 1 from each element on an odd position (having the odd index). | ||
| */ | ||
| public Double getOddNumsAverage(List<Integer> numbers) { | ||
| return 0D; | ||
| return IntStream.range(0, numbers.size()) | ||
| .map(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i)) | ||
| .filter(n -> n % 2 == 1) | ||
| .average() | ||
| .orElseThrow(() -> new NoSuchElementException("Wrong number")); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -35,7 +51,10 @@ public Double getOddNumsAverage(List<Integer> numbers) { | |
| * Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||
| */ | ||
| public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex().equals(Person.Sex.MAN) | ||
| && p.getAge() >= fromAge && p.getAge() <= toAge) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -50,7 +69,11 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA | |
| */ | ||
| public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||
| int maleToAge, List<Person> peopleList) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex().equals(Person.Sex.MAN) | ||
| ? p.getAge() >= fromAge && p.getAge() <= maleToAge | ||
| : p.getAge() >= fromAge && p.getAge() <= femaleToAge) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -59,7 +82,11 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | |
| * return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||
| */ | ||
| public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge) | ||
| .flatMap(p -> p.getCats().stream()) | ||
| .map(Cat::getName) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -75,6 +102,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | |
| * parametrized with Candidate in CandidateValidator. | ||
| */ | ||
| public List<String> validateCandidates(List<Candidate> candidates) { | ||
| return Collections.emptyList(); | ||
| CandidateValidator validator = new CandidateValidator(); | ||
| return candidates.stream() | ||
| .filter(validator) | ||
| .sorted(Comparator.comparing(Candidate::getName)) | ||
| .map(Candidate::getName) | ||
| .collect(Collectors.toList()); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This constant should be named
MIN_YEARS_IN_UKRAINEas specified in checklist item #6, notMIN_YEAR.