Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,30 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
private static final int MIN_AGE = 35;
private static final int MIN_YEARS_IN_UKRAINE = 10;
private static final String REQUIRED_NATIONALITY = "Ukrainian";
private static final String YEAR_SEPARATOR = "-";
private static final int START_YEAR_INDEX = 0;
private static final int END_YEAR_INDEX = 1;

@Override
public boolean test(Candidate candidate) {
if (candidate == null) {
return false;
}

if (candidate.getAge() < MIN_AGE
|| !candidate.isAllowedToVote()
|| !REQUIRED_NATIONALITY.equals(candidate.getNationality())) {
return false;
}
String[] years = candidate.getPeriodsInUkr().split(YEAR_SEPARATOR);
int yearsInUkr = Integer.parseInt(years[END_YEAR_INDEX])
- Integer.parseInt(years[START_YEAR_INDEX]);
return yearsInUkr >= MIN_YEARS_IN_UKRAINE;
}
}
63 changes: 57 additions & 6 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
package practice;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKLIST VIOLATION: Magic number '35' should be extracted to a constant (e.g., MIN_AGE).

import model.Person;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKLIST VIOLATION: Magic string 'Ukrainian' should be extracted to a constant.


public class StreamPractice {
Expand All @@ -14,7 +19,16 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
if (numbers == null || numbers.isEmpty()) {
throw new RuntimeException("Can't get min value from list: " + numbers);
}
return numbers.stream()
.flatMap(s -> Arrays.stream(s.split(",")))
.mapToInt(Integer::parseInt)
.filter(n -> n % 2 == 0)
.min()
.orElseThrow(() ->
new RuntimeException("Can't get min value from list: " + numbers));
}

/**
Expand All @@ -23,7 +37,15 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
if (numbers == null || numbers.isEmpty()) {
throw new NoSuchElementException("List is empty or null from list: " + numbers);
}
return IntStream.range(0, numbers.size())
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i))
.filter(n -> n % 2 != 0)
.average()
.orElseThrow(() ->
new NoSuchElementException("No odd numbers found from list: " + numbers));
}

/**
Expand All @@ -35,7 +57,13 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
if (peopleList == null || peopleList.isEmpty()) {
return Collections.emptyList();
}
return peopleList.stream()
.filter(p -> p.getSex().equals(Person.Sex.MAN))
.filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge)
.collect(Collectors.toList());
}

/**
Expand All @@ -50,7 +78,14 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
if (peopleList == null || peopleList.isEmpty()) {
return Collections.emptyList();
}
return peopleList.stream()
.filter(p -> p.getAge() >= fromAge)
.filter(p -> p.getAge() <= maleToAge && p.getSex().equals(Person.Sex.MAN)
|| p.getAge() <= femaleToAge && p.getSex().equals(Person.Sex.WOMAN))
Comment on lines +86 to +87

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter has incorrect operator precedence. Due to && binding tighter than ||, the expression groups as (age <= maleToAge && sex == MAN) || (age <= femaleToAge && sex == WOMAN). While it works currently because of the preceding filter, wrap each gender condition in parentheses for correctness: ((p.getSex().equals(Person.Sex.MAN) && p.getAge() <= maleToAge) || (p.getSex().equals(Person.Sex.WOMAN) && p.getAge() <= femaleToAge))

.collect(Collectors.toList());
}

/**
Expand All @@ -59,7 +94,15 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
if (peopleList == null || peopleList.isEmpty()) {
return Collections.emptyList();
}
return peopleList.stream()
.filter(p -> p.getAge() >= femaleAge && p.getSex().equals(Person.Sex.WOMAN))
.filter(p -> p.getCats() != null)
.flatMap(p -> p.getCats().stream())
.map(Cat::getName)
.collect(Collectors.toList());
}

/**
Expand All @@ -75,6 +118,14 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
if (candidates == null || candidates.isEmpty()) {
return Collections.emptyList();
}
CandidateValidator validator = new CandidateValidator();
return candidates.stream()
.filter(validator)
.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());
}
}
Loading