Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {

private static final String NATIONALITY = "Ukrainian";
private static final int MIN_PERIOD_IN_UKR = 10;
private static final int MIN_AGE = 35;
private static final String PERIOD_SEPARATOR = "-";

@Override
public boolean test(Candidate candidate) {
String [] years = candidate.getPeriodsInUkr().split(PERIOD_SEPARATOR);
int period = Integer.parseInt(years[1]) - Integer.parseInt(years[0]);

return candidate.getNationality().equals(NATIONALITY)
&& candidate.getAge() >= MIN_AGE
&& period >= MIN_PERIOD_IN_UKR && candidate.isAllowedToVote();
}
}
46 changes: 39 additions & 7 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
Expand All @@ -14,7 +18,14 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()
.flatMap(s -> Arrays.stream(s.split(",")))
.map(String::trim)
.mapToInt(Integer::parseInt)
.filter(n -> (n % 2) == 0)
.min()
.orElseThrow(() -> new RuntimeException("Can't get min value from list: "
+ numbers));
}

/**
Expand All @@ -23,7 +34,11 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
return IntStream.range(0, numbers.size())
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i))
.filter(i -> i % 2 != 0)
.average()
.orElseThrow(() -> new NoSuchElementException());
}

/**
Expand All @@ -35,7 +50,10 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(person -> person.getAge() >= fromAge
&& person.getAge() <= toAge && person.getSex().equals(Person.Sex.MAN))
.collect(Collectors.toList());
}

/**
Expand All @@ -50,7 +68,12 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream().filter(person -> person.getSex().equals(Person.Sex.WOMAN)
&& person.getAge() >= fromAge && person.getAge() <= femaleToAge
|| person.getSex().equals(Person.Sex.MAN)
&& person.getAge() >= fromAge && person.getAge() <= maleToAge)
Comment on lines +71 to +74

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding parentheses around the compound OR condition for better readability: (person.getSex().equals(Person.Sex.WOMAN) && person.getAge() >= fromAge && person.getAge() <= femaleToAge) || (person.getSex().equals(Person.Sex.MAN) && person.getAge() >= fromAge && person.getAge() <= maleToAge).

Comment on lines +71 to +74

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parentheses around compound OR conditions. Due to Java operator precedence, && binds tighter than ||, which may cause incorrect filtering. Each gender's condition should be wrapped in parentheses to ensure correct logical evaluation: (person.getSex().equals(Person.Sex.WOMAN) && ... && ...) || (person.getSex().equals(Person.Sex.MAN) && ... && ...)

.toList();

}

/**
Expand All @@ -59,7 +82,12 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(person -> person.getAge() >= femaleAge
&& person.getSex().equals(Person.Sex.WOMAN))
.flatMap(person -> person.getCats().stream())
.map(Cat::getName)
.collect(Collectors.toList());
}

/**
Expand All @@ -75,6 +103,10 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
return candidates.stream()
.filter(new CandidateValidator())
.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());
}
}
Loading