Skip to content

Solved stream practice#1415

Open
Constantin-Haranskiy wants to merge 3 commits into
mate-academy:mainfrom
Constantin-Haranskiy:main
Open

Solved stream practice#1415
Constantin-Haranskiy wants to merge 3 commits into
mate-academy:mainfrom
Constantin-Haranskiy:main

Conversation

@Constantin-Haranskiy

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation has a logic error in Task 2 (getOddNumsAverage()). The current approach filters elements first, then applies a map operation to all elements, which loses position context after filtering. This means the position-based logic (subtracting 1 from even-indexed elements) is applied incorrectly, producing wrong average results. The fix requires ensuring position context is preserved when applying the subtraction logic to even-indexed elements before filtering for odd results. Tasks 1, 3, 4, 5, and 6 are implemented correctly using Stream API and meet all requirements. Please fix the logic in getOddNumsAverage() to correctly handle the positional operation.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is complete and correct. All six tasks pass their requirements: Task 2's index preservation issue has been properly fixed using IntStream.range(), Stream API usage is correct across all methods, enum comparisons use .equals() as required, and CandidateValidator correctly implements Predicate<Candidate> with constants for magic numbers. The validateCandidates() method properly uses your custom predicate implementation with alphabetical sorting. Excellent work on fixing the stream indexing issue in Task 2—using IntStream.range() to maintain position context before subtraction is the correct approach.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants