sorted variables#3534
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation correctly categorizes all 8 variables into mutable and immutable lists, which is great work. However, there's a syntax error on line 21 that prevents the code from running: the dictionary assignment uses : = instead of : for the "immutable" key. The issue: Change line 21 from "immutable": = [...]" to "immutable": [...]" — dictionary values only need a colon, not a colon-equals. Once you remove that extra = sign, the code will work correctly since the variable categorization logic itself is sound.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| # write your code here | ||
| sorted_variables = { | ||
| "mutable": [my_favourite_films, collection_of_coins, marks], | ||
| "immutable": = [lucky_number, pi, name, one_is_a_prime_number, profile_info] |
There was a problem hiding this comment.
Syntax error: There's an extra = sign after the key. Dictionary syntax should be "immutable": [...] not "immutable": = [...].
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jakubrenusz123-blip
left a comment
jakubrenusz123-blip
left a comment
There was a problem hiding this comment.
changed permissions
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation correctly creates the sorted_variables dictionary with the proper structure, organizing all 8 variables into their correct categories—mutable types (list, set, dict) and immutable types (int, float, str, bool, tuple). The dictionary keys match the required format exactly. Great work on completing this task successfully!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.