Skip to content

Solution#227

Open
pryge wants to merge 1 commit intomate-academy:masterfrom
pryge:develop
Open

Solution#227
pryge wants to merge 1 commit intomate-academy:masterfrom
pryge:develop

Conversation

@pryge
Copy link

@pryge pryge commented Nov 20, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your tests correctly use Jest mocks to validate both the true and false pathways of the ifElse function, meeting all the core requirements. I am approving your solution.

I have one small suggestion for improvement. In src/ifElse.test.js, the description for the second test case is a duplicate of the first. It would be clearer if you updated it to reflect that the test handles the scenario where the condition callback returns false. This is a minor point, and your implementation is solid.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

});

// write tests here
it('should return first if condition is true', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for this test case appears to be copied from the one above. It should be updated to reflect that this test handles the scenario where the condition callback returns false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants