Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this! Your solution correctly implements the core logic for the ifElse function, and your tests effectively cover both the true and false paths. I am approving your submission.
To make your tests even more robust in the future, consider verifying all aspects of the requirements. For instance, you could assert that the callbacks are called with no arguments using toHaveBeenCalledWith(). Additionally, a test to confirm that the ifElse function itself returns undefined would fully cover the requirements.
These are points for improvement, but your current implementation successfully meets the core goals. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| it(`should call 'first' if 'condition' returns true`, () => { | ||
| condition.mockReturnValue(true); | ||
| ifElse(condition, first, second); | ||
| expect(first).toHaveBeenCalled(); |
There was a problem hiding this comment.
This correctly verifies that the first callback is executed. The requirements also state that callbacks should be run 'with no arguments'. To make this test more precise, you could also check that both condition and first were called without any arguments using toHaveBeenCalledWith().
| condition.mockReturnValue(false); | ||
| ifElse(condition, first, second); | ||
| expect(first).not.toHaveBeenCalled(); | ||
| expect(second).toHaveBeenCalled(); |
There was a problem hiding this comment.
This check is correct. To fully align with the requirements, consider also asserting that both the condition and second callbacks were called without arguments.
2 participants
No description provided.