qa ifElse function solution#233
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on writing the tests for the ifElse function! I am approving your solution as you have successfully covered all the requirements from the description, and the test structure is logical.
As a small suggestion for future improvement, you can make your tests even more concise. In src/ifElse.test.js, the assertion on line 28 duplicates the one on line 25, and the assertion on line 31 duplicates the one on line 26. Removing these repeated checks would make the test case cleaner. This is a minor point, and overall, this is a solid set of tests.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| expect(first).toHaveBeenCalledTimes(1); | ||
| expect(first).toHaveBeenCalledWith(); | ||
|
|
||
| expect(second).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
These checks are redundant. The assertion on line 28 duplicates the one on line 25, and the assertion on line 31 duplicates the one on line 26. You can remove these repeated checks to keep your test case more concise.
2 participants
No description provided.