Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This submission requires a few changes before it can be approved. While the updates to the project tooling like Prettier are good additions, the primary requirement of implementing tests for the ifElse function has not yet been met. The file src/ifElse.test.js still contains the initial placeholder code.
Please add test cases to verify the function's behavior. Specifically, you should test that:
- The
firstcallback is executed when theconditionfunction returnstrue. - The
secondcallback is executed when theconditionfunction returns a non-truevalue.
Using jest.fn() to create mock functions for the callbacks is a great way to check if they were called correctly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| it('should ', () => {}); | ||
|
|
||
| // write tests here |
There was a problem hiding this comment.
It looks like this is placeholder code. You need to implement the tests for the ifElse function here. Remember to uncomment the import on line 4 and write tests to check if the correct callback is called based on the condition's return value. Using mock functions like jest.fn() will be very helpful for this.
added prettier and updated packages and node.js for gh actions