Skip to content

Feature/prettier#246

Merged
marina-tilniak merged 1 commit intomate-academy:masterfrom
mykhalenych:feature/prettier
Mar 11, 2026
Merged

Feature/prettier#246
marina-tilniak merged 1 commit intomate-academy:masterfrom
mykhalenych:feature/prettier

Conversation

@mykhalenych
Copy link
Contributor

added prettier and updated packages and node.js for gh actions

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This submission requires a few changes before it can be approved. While the updates to the project tooling like Prettier are good additions, the primary requirement of implementing tests for the ifElse function has not yet been met. The file src/ifElse.test.js still contains the initial placeholder code.

Please add test cases to verify the function's behavior. Specifically, you should test that:

  • The first callback is executed when the condition function returns true.
  • The second callback is executed when the condition function returns a non-true value.

Using jest.fn() to create mock functions for the callbacks is a great way to check if they were called correctly.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment on lines +6 to 8
it('should ', () => {});

// write tests here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is placeholder code. You need to implement the tests for the ifElse function here. Remember to uncomment the import on line 4 and write tests to check if the correct callback is called based on the condition's return value. Using mock functions like jest.fn() will be very helpful for this.

@marina-tilniak marina-tilniak merged commit c5ab829 into mate-academy:master Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants