session: restart non-client apps that set AutoRestart#334
Open
session: restart non-client apps that set AutoRestart#334
Conversation
Apps like Orca set X-GNOME-AutoRestart=true in their .desktop files expecting to be restarted after a crash. However, the restart logic only handled apps that registered as XSMP or D-Bus clients. Non-client apps emitted "died"/"exited" signals but nothing subscribed to them. This bug was inherited from gnome-session. Connect the "died" and "exited" signals on autostart apps to trigger restart for non-client apps with AutoRestart enabled. Also fall back to X-GNOME-AutoRestart when X-MATE-AutoRestart is not present, for compatibility with apps that only set the GNOME key. Fixes #321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps like Orca set
X-GNOME-AutoRestart=truein their .desktop files expecting to be restarted after a crash. However, the restart logic only handled apps that registered as XSMP or D-Bus clients. Non-client apps emitted "died"/"exited" signals but nothing subscribed to them. This bug was inherited from gnome-session.Connect the "died" and "exited" signals on autostart apps to trigger restart for non-client apps with AutoRestart enabled. Also fall back to
X-GNOME-AutoRestartwhenX-MATE-AutoRestartis not present, for compatibility with apps that only set the GNOME key.Fixes #321