Allow close keyboard shortcut to close the window when empty#709
Open
mdeslaur wants to merge 1 commit intomate-desktop:masterfrom
Open
Allow close keyboard shortcut to close the window when empty#709mdeslaur wants to merge 1 commit intomate-desktop:masterfrom
mdeslaur wants to merge 1 commit intomate-desktop:masterfrom
Conversation
When there are no open tabs, the close keyboard shortcut was being disabled. This change allows the shortcut to close the main window when no tabs are open, matching the behaviour in other applications that use tabs, such as Firefox.
vkareh
requested changes
Mar 18, 2026
Member
vkareh
left a comment
vkareh
left a comment
There was a problem hiding this comment.
Simple and works well, thanks! However, there's an inconsistency with saved sessions that needs to be addressed.
| !(window->priv->state & PLUMA_WINDOW_STATE_SAVING) && | ||
| !(window->priv->state & PLUMA_WINDOW_STATE_PRINTING)); | ||
|
|
||
| gtk_action_group_set_sensitive (window->priv->close_action_group, |
Member
There was a problem hiding this comment.
There's already a call to toggle sensitivity of close_action_group below in this same function. Can you make sure you consolidate the conditionals to avoid one undoing the other? Otherwise the close action can get re-disabled with zero tabs after leaving a session-save state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no open tabs, the close keyboard shortcut was being disabled. This change allows the shortcut to close the main window when no tabs are open, matching the behaviour in other applications that use tabs, such as Firefox.