Conversation
Co-authored-by: mateofra <111438182+mateofra@users.noreply.github.com>
Co-authored-by: mateofra <111438182+mateofra@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR switches the site’s presentation from the default Minima look to a custom “90s retro” theme by introducing a bespoke Jekyll default layout and a dedicated retro stylesheet, and regenerating the built site output accordingly.
Changes:
- Added a custom Jekyll layout (
_layouts/default.html) with marquee banner, under-construction notice, visitor counter, and themed header/footer. - Added retro styling (
assets/css/retro.css) to implement the 90s visual design across the site. - Updated generated site output under
_site/to reflect the new layout/theme and updated canonical URLs/feed content.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
assets/css/retro.css |
New retro theme CSS (colors, fonts, blink animation, terminal-style code blocks, etc.). |
_layouts/default.html |
New site-wide layout implementing the retro structure (header/nav, marquee, footer blocks). |
_site/index.html |
Generated homepage output updated to the new layout/theme and URLs. |
_site/markdown.html |
Generated markdown page output updated to the new layout/theme and URLs. |
_site/404.html |
Generated 404 page output updated to the new layout/theme and URLs. |
_site/feed.xml |
Generated Atom feed updated (site URLs, updated timestamp, entries). |
_site/assets/css/retro.css |
Generated copy of the retro stylesheet in the build output. |
_site/2025/08/25/Linux.html |
Generated new post/page output using the retro layout. |
_site/2025/08/23/compre-un-ordenador-por-40-euros.html |
Generated post output updated to the retro layout/theme and URLs/timezone. |
_site/jekyll/update/2025/08/20/welcome-to-jekyll.html |
Generated legacy post output removed from build output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <p style="margin-top: 10px; font-size: 0.8em; color: #AAAAAA;"> | ||
| © {{ site.time | date: "%Y" }} {{ site.title | escape }} — | ||
| Hecho con ❤️ y <a href="https://jekyllrb.com" style="color: #00FF00 !important;">Jekyll</a> |
There was a problem hiding this comment.
This footer paragraph uses inline styling (margin/font-size/color) and an inline style on the Jekyll link. Please move these styles into retro.css classes so they can be reused/overridden cleanly (and to keep HTML focused on structure/content).
| <p style="margin-top: 10px; font-size: 0.8em; color: #AAAAAA;"> | |
| © {{ site.time | date: "%Y" }} {{ site.title | escape }} — | |
| Hecho con ❤️ y <a href="https://jekyllrb.com" style="color: #00FF00 !important;">Jekyll</a> | |
| <p class="footer-meta"> | |
| © {{ site.time | date: "%Y" }} {{ site.title | escape }} — | |
| Hecho con ❤️ y <a href="https://jekyllrb.com" class="footer-meta-jekyll-link">Jekyll</a> |
| 0%, 100% { visibility: visible; } | ||
| 50% { visibility: hidden; } | ||
| } | ||
|
|
There was a problem hiding this comment.
The .blink animation should respect users who prefer reduced motion (and blinking content can be problematic for accessibility). Add a @media (prefers-reduced-motion: reduce) override to disable the animation (and consider reducing/removing the blink effect by default).
| @media (prefers-reduced-motion: reduce) { | |
| .blink { | |
| animation: none; | |
| visibility: visible; | |
| } | |
| } |
| } | ||
|
|
||
| img { | ||
| border: 3px ridge #FF00FF; |
There was a problem hiding this comment.
img sets a border but doesn't constrain image sizing. Large images can overflow the 800px wrapper (or overflow on any future responsive changes). Add max-width: 100% and height: auto to keep images within their container.
| border: 3px ridge #FF00FF; | |
| border: 3px ridge #FF00FF; | |
| max-width: 100%; | |
| height: auto; |
| <link rel="stylesheet" href="/assets/css/retro.css"> | ||
| <link type="application/atom+xml" rel="alternate" href="/feed.xml" title="Wow"> | ||
| </head> |
There was a problem hiding this comment.
These _site/* HTML files are generated Jekyll build artifacts (and will churn on every build due to timestamps/URLs). Since the repo already has a GitHub Pages build workflow that outputs to ./_site, avoid committing _site and instead add it to .gitignore and remove these files from the PR to keep diffs reviewable and prevent merge conflicts.
| <?xml version="1.0" encoding="utf-8"?><feed xmlns="http://www.w3.org/2005/Atom" ><generator uri="https://jekyllrb.com/" version="3.10.0">Jekyll</generator><link href="https://mateofra.github.io/feed.xml" rel="self" type="application/atom+xml" /><link href="https://mateofra.github.io/" rel="alternate" type="text/html" /><updated>2026-03-04T15:13:14+00:00</updated><id>https://mateofra.github.io/feed.xml</id><title type="html">Wow</title><subtitle>Hola.</subtitle><entry><title type="html">Linux</title><link href="https://mateofra.github.io/2025/08/25/Linux.html" rel="alternate" type="text/html" title="Linux" /><published>2025-08-25T00:00:00+00:00</published><updated>2025-08-25T00:00:00+00:00</updated><id>https://mateofra.github.io/2025/08/25/Linux</id><content type="html" xml:base="https://mateofra.github.io/2025/08/25/Linux.html"><![CDATA[<p>Que el portatil que mi padre me compró para mis estudios universitarios viniese sin sistema operativo causó que de golpe abandonase el ecosistema Windows. Un error en mi Asus Vivobook impedía que el instalador detectase el disco duro. Tras unos cuantos intentos decidí comprobar si un instalador de otro SO funcionaría, así que “investigué” que “flavour” de GNU/Linux sería funcional en las manos de un completo novato.</p> | ||
| <blockquote> | ||
| <p>Mejor distro linux 2022.<br /> |
There was a problem hiding this comment.
_site/feed.xml is also generated output and includes an <updated> timestamp that will change on each build, causing perpetual noisy diffs. It should be removed from the repo along with the rest of _site/ and regenerated during deployment.
| <div class="marquee-wrapper"> | ||
| <marquee behavior="scroll" direction="left"> | ||
| ★ ¡Bienvenido a mi página web! ★ | ||
| ★ Welcome to the Information Superhighway! ★ | ||
| ★ Best viewed in 800x600 resolution ★ | ||
| ★ Netscape Navigator 4.0 recommended ★ | ||
| ★ ¡Esta página está en construcción! ★ | ||
| </marquee> | ||
| </div> |
There was a problem hiding this comment.
This layout uses a scrolling <marquee>, which is deprecated and creates significant accessibility issues (no pause/stop control; problematic for motion sensitivity and screen readers). Consider replacing it with a CSS animation that can be disabled via prefers-reduced-motion, and/or provide a non-animated fallback + a user control to pause the animation.
| <div style="text-align: center; padding: 10px;"> | ||
| <span>Visitas: </span> | ||
| <span class="visitor-counter">001337</span> | ||
| <br><br> | ||
| <div class="best-viewed"> | ||
| 🖥️ Esta página se ve mejor con Netscape Navigator 4.0 en resolución 800×600 | IE 5.0 compatible | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Inline styles here make the layout harder to maintain/theme (and force overrides to use higher specificity). Please move these presentation concerns into assets/css/retro.css via a dedicated class (e.g., for the centered counter block) instead of style="..." attributes.
Replaces the default minima theme with a fully retro 90s web experience using custom Jekyll layout and CSS overrides.
Layout (
_layouts/default.html)<marquee>banner with era-appropriate phrases ("Welcome to the Information Superhighway!", "Best viewed in 800×600", "Netscape Navigator 4.0 recommended")001337visitor counter in green-on-black monospace<hr>dividersStyles (
assets/css/retro.css)blinkkeyframe animation for construction warningScreenshot
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.