Forcefield roundtrip when specifying monty dict#1461
Forcefield roundtrip when specifying monty dict#1461esoteric-ephemera wants to merge 5 commits intomainfrom
Conversation
|
Hi @esoteric-ephemera, thanks for implementing this fix. I think the solution may be fine, but I wonder if the fact of transforming the dict into an ad hoc string would not increase the likelyhood of ending up with backward incompatible updates later on. It seems that this string serialization may complicate any different use of dict or str values for However, if you expect that v0.2.0 will introduce breaking changes anyway, it may not be worth to focus on potential future issues here. |
|
Thanks @gpetretto and good point. I added a bit more logic to the deserialization that should handle cases when If you have some legacy docs where you could test that this correctly handles legacy docs, would appreciate it! |
|
Thanks for this update! I have tested and it seems to work fine deserializing this type of makers. I should mention that in my previous message I was also refferring to potentially future incompatibilities. Serializing the dictionary with |
Closes #1460:
force_field_nameas amonty-style dictcalculator_metaas a dot-separated import str (preferred)calculator_metaas amonty-style dictFor the next minor release (v0.2.0), the forcefield interface could use some significant simplification. This will just serve as a patch