fix: theme members settings UI#35
Draft
James-at-TrueGroup wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Settings > Members UI so the members list, pending invitations list, role badges, form controls, error state, and invite modal use the existing theme tokens instead of hardcoded light/dark Tailwind colors.
This addresses the members table rendering as a bright white card inside the dark settings page.
Screenshots
Before/after references were generated locally with
before-and-afterfrom the reported screenshot and a static token preview. Public image upload failed from this environment, so screenshots are not embedded here.Testing
npm run typecheckNote: local Vite preview is currently blocked by an existing dependency optimizer failure in esbuild (
Transforming destructuring to the configured target environment ... is not supported yet), before the app page loads.