test: review all test files against testing guidelines#60
Merged
Conversation
Ran iterative par5 review across all 61 test files against
docs/testing.md until full convergence (5 passes, 0 remaining
violations).
Key changes applied across the codebase:
- Split multi-concept tests (names with "and", multiple unrelated assertions)
- Renamed tests from function-oriented to condition+outcome naming
- Removed logic (loops, conditionals, inline filters) from test bodies
- Replaced `.to_string().contains(...)` error string matching with
`assert!(matches!(err, Variant { .. }))` where enum variants exist
- Removed tests that verified framework/library behaviour (serde defaults)
- Fixed isolation: OS-assigned ports, temp dirs, removed shared globals
- Added missing `#[ignore]` annotations for external-service tests
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/testing.mduntil full convergence (5 passes, 0 remaining violations).to_string().contains(...)error string matching withassert!(matches!(err, Variant { .. }))where enum variants exist#[ignore]annotations for external-service testsTest plan
cargo test --no-runpasses — all 60 modified files compile clean🤖 Generated with Claude Code