Conversation
Member
Author
|
Scott, please especially review the new test fixtures. Thanks. |
MWSestabro
approved these changes
Jul 16, 2025
Member
MWSestabro
left a comment
MWSestabro
left a comment
There was a problem hiding this comment.
The new test fixture and changes look good, this should resolve issues related to drool in the testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new static method unsetTracerProvider to opentelemetry.trace.Provider, which unsets the global tracer provider and disables tracing from new tracers.
Similarly, add unsetMeterProvider and unsetLoggerProvider for metrics and logs.
Use the new methods in tests for clean up. Tests that set the global provider previously drool the provider change (output state is not the same as input state). With this additional cleanup, the state of each test after running can be identical to before running.
Fixes #162