Fix to the partial fix for #89 and updating workflow dependencies#90
Merged
Conversation
Contributor
danelahman
commented
Nov 8, 2025
danelahman
commented
- A fix to the @matijapretnar's partial fix for Assertion failed on line 333 of substitution.ml #89
- Previous fix was using an unbound variable, and apply_sub_dirtcoer was not applied in the case when two dirt params are equal
- Updated workflow dependencies for GitHub Pages and test to get GitHub Actions to work again
- From avsm/ocaml-setup to ocaml/setup-ocaml
…re equal (related to matijapretnar#89)
(The one I forgot to stage when making the previous commit)
Owner
|
Sorry for the confusion, my partial fix was only partially committed. Everything should now be as expected. Thank you for bringing this up and for fixing the GitHub action! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.